Commit d9f68cef by Yonatan Kahana

Fix typo in CHANGELOG and change provisioner name to use the sigs namespace

parent 56edbc01
# v4.0.0 # v4.0.0
- Remove redundant field in the rbac.yaml (https://github.com/kubernetes-retired/external-storage/pull/970) - Remove redundant field in the rbac.yaml (https://github.com/kubernetes-retired/external-storage/pull/970)
- Use `kubernetes-sigs/sig-storage-lib-external-provisioner` instaed of `incubator/external-storage/lib` (https://github.com/kubernetes-retired/external-storage/pull/1026) - Use `kubernetes-sigs/sig-storage-lib-external-provisioner` instead of `incubator/external-storage/lib` (https://github.com/kubernetes-retired/external-storage/pull/1026)
- Fill in rbac.yaml with ServiceAccount manifest (https://github.com/kubernetes-retired/external-storage/pull/1060, https://github.com/kubernetes-retired/external-storage/pull/1179) - Fill in rbac.yaml with ServiceAccount manifest (https://github.com/kubernetes-retired/external-storage/pull/1060, https://github.com/kubernetes-retired/external-storage/pull/1179)
- Make ARM deployment consistent with regular deployment (https://github.com/kubernetes-retired/external-storage/pull/1090) - Make ARM deployment consistent with regular deployment (https://github.com/kubernetes-retired/external-storage/pull/1090)
- Update Deployment apiVersion (from `extensions/v1beta1` to `apps/v1`) and added selector field (https://github.com/kubernetes-retired/external-storage/pull/1230/, https://github.com/kubernetes-retired/external-storage/pull/1231/, https://github.com/kubernetes-retired/external-storage/pull/1283/, https://github.com/kubernetes-retired/external-storage/pull/1294/) - Update Deployment apiVersion (from `extensions/v1beta1` to `apps/v1`) and added selector field (https://github.com/kubernetes-retired/external-storage/pull/1230/, https://github.com/kubernetes-retired/external-storage/pull/1231/, https://github.com/kubernetes-retired/external-storage/pull/1283/, https://github.com/kubernetes-retired/external-storage/pull/1294/)
......
...@@ -107,7 +107,7 @@ spec: ...@@ -107,7 +107,7 @@ spec:
mountPath: /persistentvolumes mountPath: /persistentvolumes
env: env:
- name: PROVISIONER_NAME - name: PROVISIONER_NAME
value: nfs-subdir-external-provisioner value: k8s-sigs.io/nfs-subdir-external-provisioner
- name: NFS_SERVER - name: NFS_SERVER
value: <YOUR NFS SERVER HOSTNAME> value: <YOUR NFS SERVER HOSTNAME>
- name: NFS_PATH - name: NFS_PATH
...@@ -119,7 +119,7 @@ spec: ...@@ -119,7 +119,7 @@ spec:
path: /var/nfs path: /var/nfs
``` ```
You may also want to change the PROVISIONER_NAME above from `nfs-subdir-external-provisioner` to something more descriptive like `nfs-storage`, but if you do remember to also change the PROVISIONER_NAME in the storage class definition below. You may also want to change the PROVISIONER_NAME above from `k8s-sigs.io/nfs-subdir-external-provisioner` to something more descriptive like `nfs-storage`, but if you do remember to also change the PROVISIONER_NAME in the storage class definition below.
To disable leader election, define an env variable named ENABLE_LEADER_ELECTION and set its value to false. To disable leader election, define an env variable named ENABLE_LEADER_ELECTION and set its value to false.
...@@ -140,7 +140,7 @@ apiVersion: storage.k8s.io/v1 ...@@ -140,7 +140,7 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass kind: StorageClass
metadata: metadata:
name: managed-nfs-storage name: managed-nfs-storage
provisioner: nfs-subdir-external-provisioner # or choose another name, must match deployment's env PROVISIONER_NAME' provisioner: k8s-sigs.io/nfs-subdir-external-provisioner # or choose another name, must match deployment's env PROVISIONER_NAME'
parameters: parameters:
pathPattern: "${.PVC.namespace}/${.PVC.annotations.nfs.io/storage-path}" # waits for nfs.io/storage-path annotation, if not specified will accept as empty string. pathPattern: "${.PVC.namespace}/${.PVC.annotations.nfs.io/storage-path}" # waits for nfs.io/storage-path annotation, if not specified will accept as empty string.
onDelete: delete onDelete: delete
......
...@@ -2,6 +2,6 @@ apiVersion: storage.k8s.io/v1 ...@@ -2,6 +2,6 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass kind: StorageClass
metadata: metadata:
name: managed-nfs-storage name: managed-nfs-storage
provisioner: nfs-subdir-external-provisioner # or choose another name, must match deployment's env PROVISIONER_NAME' provisioner: k8s-sigs.io/nfs-subdir-external-provisioner # or choose another name, must match deployment's env PROVISIONER_NAME'
parameters: parameters:
archiveOnDelete: "false" archiveOnDelete: "false"
...@@ -27,7 +27,7 @@ spec: ...@@ -27,7 +27,7 @@ spec:
mountPath: /persistentvolumes mountPath: /persistentvolumes
env: env:
- name: PROVISIONER_NAME - name: PROVISIONER_NAME
value: nfs-subdir-external-provisioner value: k8s-sigs.io/nfs-subdir-external-provisioner
- name: NFS_SERVER - name: NFS_SERVER
value: 10.10.10.60 value: 10.10.10.60
- name: NFS_PATH - name: NFS_PATH
......
...@@ -27,7 +27,7 @@ spec: ...@@ -27,7 +27,7 @@ spec:
mountPath: /persistentvolumes mountPath: /persistentvolumes
env: env:
- name: PROVISIONER_NAME - name: PROVISIONER_NAME
value: nfs-subdir-external-provisioner value: k8s-sigs.io/nfs-subdir-external-provisioner
- name: NFS_SERVER - name: NFS_SERVER
value: 10.10.10.60 value: 10.10.10.60
- name: NFS_PATH - name: NFS_PATH
......
...@@ -2,6 +2,6 @@ apiVersion: storage.k8s.io/v1 ...@@ -2,6 +2,6 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass kind: StorageClass
metadata: metadata:
name: managed-nfs-storage name: managed-nfs-storage
provisioner: nfs-subdir-external-provisioner # or choose another name, must match deployment's env PROVISIONER_NAME' provisioner: k8s-sigs.io/nfs-subdir-external-provisioner # or choose another name, must match deployment's env PROVISIONER_NAME'
parameters: parameters:
archiveOnDelete: "false" archiveOnDelete: "false"
...@@ -20,7 +20,7 @@ spec: ...@@ -20,7 +20,7 @@ spec:
mountPath: /persistentvolumes mountPath: /persistentvolumes
env: env:
- name: PROVISIONER_NAME - name: PROVISIONER_NAME
value: nfs-subdir-external-provisioner value: k8s-sigs.io/nfs-subdir-external-provisioner
- name: NFS_SERVER - name: NFS_SERVER
value: 10.10.10.60 value: 10.10.10.60
- name: NFS_PATH - name: NFS_PATH
......
...@@ -20,7 +20,7 @@ spec: ...@@ -20,7 +20,7 @@ spec:
mountPath: /persistentvolumes mountPath: /persistentvolumes
env: env:
- name: PROVISIONER_NAME - name: PROVISIONER_NAME
value: nfs-subdir-external-provisioner value: k8s-sigs.io/nfs-subdir-external-provisioner
- name: NFS_SERVER - name: NFS_SERVER
value: 10.10.10.60 value: 10.10.10.60
- name: NFS_PATH - name: NFS_PATH
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment