Update minimum rancher version in Istio charts

Due to changes in the UI of the Istio chart we need to add minimum Rancher versions to ensure that the Istio chart will display its UI elements correctly within Rancher.

Update minimum rancher version in Istio charts
088598ee · Dax McDonald · Denise · d67dd3f9 · 088598ee · 088598ee
Commit 088598ee authored Jan 13, 2020 by Dax McDonald Committed by Denise Jan 13, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 5 deletions

questions.yaml charts/rancher-istio/1.4.3/questions.yaml +1 -1

update-istio-release scripts/update-istio-release +6 -4

No files found.
--- a/charts/rancher-istio/1.4.3/questions.yaml
+++ b/charts/rancher-istio/1.4.3/questions.yaml
 labels:
  rancher.istio.v1.4.3: 1.4.3
-rancher_min_version: 2.3.0-rc1
+rancher_min_version: 2.3.4-rc1
--- a/scripts/update-istio-release
+++ b/scripts/update-istio-release
@@ -45,11 +45,14 @@ EOF
 done
 rm -r charts/rancher-istio/${1}/charts/istio-init

-# Add question.yaml
+# Add question.yaml, make need to update minimum rancher version
+RANCHER_MIN_VERSION="2.3.4-rc1"
+echo "Current rancher min version is set to $RANCHER_MIN_VERSION"
+
 cat > charts/rancher-istio/${1}/questions.yaml << EOF
 labels:
  rancher.istio.v${1}: ${1}
-rancher_min_version: 2.3.0-rc1
+rancher_min_version: $RANCHER_MIN_VERSION
 EOF

 # Replace the name of the chart
@@ -67,4 +70,4 @@ cat ./scripts/istio/istio-values.yaml > charts/rancher-istio/${1}/values.yaml
 cat ./scripts/istio/istio-service-rbac.yaml > charts/rancher-istio/${1}/templates/istio-service-rbac.yaml

 # Replace tag
-sed -i 's/tag: 1.4.2/tag: '"${1}"'/g' charts/rancher-istio/${1}/values.yaml
\ No newline at end of file
+sed -i 's/tag: 1.4.2/tag: '"${1}"'/g' charts/rancher-istio/${1}/values.yaml