Skip to content

N
nfs-subdir-external-provisioner
Unverified Commit f6c74b30 by Kubernetes Prow Robot Committed by GitHub
Options

Merge pull request #57 from ggriffiths/version_gt_kubernetes_fix

Fix version_gt to work with Kubernetes prefix
parents 9f1f3dd8 fc809759
Showing with 3 additions and 1 deletion
prow.sh
...@@ -1013,6 +1013,7 @@ make_test_to_junit () { ...@@ -1013,6 +1013,7 @@ make_test_to_junit () {
# The follow substrings are stripped before version comparison: # The follow substrings are stripped before version comparison:
# - "v" # - "v"
# - "release-" # - "release-"
# - "kubernetes-"
# #
# Usage: # Usage:
# version_gt release-1.3 v1.2.0 (returns true) # version_gt release-1.3 v1.2.0 (returns true)
...@@ -1022,8 +1023,9 @@ make_test_to_junit () { ...@@ -1022,8 +1023,9 @@ make_test_to_junit () {
# version_gt 1.1.1 release-1.2.0 (returns false) # version_gt 1.1.1 release-1.2.0 (returns false)
# version_gt 1.2.0 1.2.2 (returns false) # version_gt 1.2.0 1.2.2 (returns false)
function version_gt() { function version_gt() {
versions=$(for ver in "$@"; do ver=${ver#release-}; echo "${ver#v}"; done) versions=$(for ver in "$@"; do ver=${ver#release-}; ver=${ver#kubernetes-}; echo "${ver#v}"; done)
greaterVersion=${1#"release-"}; greaterVersion=${1#"release-"};
greaterVersion=${greaterVersion#"kubernetes-"};
greaterVersion=${greaterVersion#"v"}; greaterVersion=${greaterVersion#"v"};
test "$(printf '%s' "$versions" | sort -V | head -n 1)" != "$greaterVersion" test "$(printf '%s' "$versions" | sort -V | head -n 1)" != "$greaterVersion"
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment